Skip to content

CLN: cleanup hashtable.pyx #10111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2015
Merged

CLN: cleanup hashtable.pyx #10111

merged 1 commit into from
May 13, 2015

Conversation

gdementen
Copy link
Contributor

mostly remove unused stuff

@jreback jreback added the Compat pandas objects compatability with Numpy or Python functions label May 12, 2015
@jreback jreback added this to the 0.17.0 milestone May 12, 2015
@jreback
Copy link
Contributor

jreback commented May 12, 2015

looks ok. pls squash to a single commit when you are done. ping when green.

@gdementen
CLN: cleanup hashtable.pyx
c2b58cb 
remove unused variables and commented debug code
do not store result of kh_put* when it is not used
use khiter_t instead of int
rename val & max_val to count & max_count for readability & consistency
@gdementen
Copy link
Contributor Author

@jreback ping! :)

@gdementen gdementen changed the title Misc cleanup of hashtable.pyx CLN: cleanup hashtable.pyx May 13, 2015
@jreback jreback added Clean and removed Compat pandas objects compatability with Numpy or Python functions labels May 13, 2015
jreback added a commit that referenced this pull request May 13, 2015
@jreback
Merge pull request #10111 from gdementen/hashtablecleanup
b32f218 
CLN: cleanup hashtable.pyx
@jreback jreback merged commit b32f218 into pandas-dev:master May 13, 2015
@jreback
Copy link
Contributor

jreback commented May 13, 2015

thanks!

@gdementen gdementen deleted the hashtablecleanup branch May 13, 2015 12:29
@jorisvandenbossche jorisvandenbossche modified the milestones: 0.17.0, 0.16.2 Jun 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
0.16.2
Development

Successfully merging this pull request may close these issues.
3 participants
@gdementen @jreback @jorisvandenbossche